From 40afbc1908dc278cdc630a877bf96a56c6731bcd Mon Sep 17 00:00:00 2001 From: James Graham Date: Tue, 3 Mar 2020 13:42:46 +0000 Subject: [PATCH] fix: Fix broken user check when anonymous --- people/permissions.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/people/permissions.py b/people/permissions.py index a9edb85..2e6c585 100644 --- a/people/permissions.py +++ b/people/permissions.py @@ -30,4 +30,8 @@ class UserIsLinkedPersonMixin(UserPassesTestMixin): return getattr(self.get_object(), self.related_person_field) def test_func(self) -> bool: - return self.request.user.is_staff or self.get_test_person() == self.request.user.person + """ + Require that user is either staff or is the linked person. + """ + user = self.request.user + return user.is_authenticated and (user.is_staff or self.get_test_person() == user.person)