refactor: Rename Person serializers

This commit is contained in:
James Graham
2020-04-01 16:23:16 +01:00
parent d02f865952
commit 7d1aac2021
3 changed files with 6 additions and 6 deletions

View File

@@ -7,7 +7,7 @@ from people import models
from . import base from . import base
class PersonSerializer(serializers.ModelSerializer): class SimplePersonSerializer(serializers.ModelSerializer):
class Meta: class Meta:
model = models.Person model = models.Person
fields = [ fields = [
@@ -16,7 +16,7 @@ class PersonSerializer(serializers.ModelSerializer):
] ]
class PersonExportSerializer(serializers.ModelSerializer): class PersonSerializer(base.FlattenedModelSerializer):
class Meta: class Meta:
model = models.Person model = models.Person
fields = [ fields = [
@@ -31,8 +31,8 @@ class PersonExportSerializer(serializers.ModelSerializer):
class RelationshipSerializer(base.FlattenedModelSerializer): class RelationshipSerializer(base.FlattenedModelSerializer):
source = PersonSerializer() source = SimplePersonSerializer()
target = PersonSerializer() target = SimplePersonSerializer()
class Meta: class Meta:
model = models.Relationship model = models.Relationship

View File

@@ -6,7 +6,7 @@ from people import models
class PersonExportView(base.CsvExportView): class PersonExportView(base.CsvExportView):
model = models.person.Person model = models.person.Person
serializer_class = serializers.people.PersonExportSerializer serializer_class = serializers.people.PersonSerializer
class RelationshipExportView(base.CsvExportView): class RelationshipExportView(base.CsvExportView):

View File

@@ -43,7 +43,7 @@ class RelationshipQuestion(models.Model):
@property @property
def choices(self) -> typing.List[typing.List[str]]: def choices(self) -> typing.List[typing.List[str]]:
""" """
Convert the :class:`RelationshipQuestionChoices` for this question into Django choices. Convert the :class:`RelationshipQuestionChoice`s for this question into Django choices.
""" """
return [ return [
[choice.pk, str(choice)] for choice in self.answers.all() [choice.pk, str(choice)] for choice in self.answers.all()