From 2d3e8d9224d72d37d3363b28210e6463b89c6b24 Mon Sep 17 00:00:00 2001 From: Matthew Grove Date: Thu, 16 May 2024 23:52:37 +0100 Subject: [PATCH] [FIX] Brightness adjustment Ensure current brightness value is used in calculations, not the previous one Ensure holding volume buttons continues to change volume, even if data hasn't been refreshed from remove --- screens.py | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/screens.py b/screens.py index 2a98cb6..ddee8eb 100644 --- a/screens.py +++ b/screens.py @@ -182,12 +182,16 @@ class LightsScreen(Screen): toggleLight(self.es[i]["id"]) a = True # if up/down clicked, adjust brightness for all lights that are turned on - pcfg = i in self.prev and "on" in self.prev[i] and self.prev[i]["on"] and "brightness" in self.prev[i] + pcfg = i in self.d and "on" in self.d[i] and self.d[i]["on"] and "brightness" in self.d[i] if (up and pcfg): - setBrightness(self.es[i]["id"], min(255, self.prev[i]["brightness"] + 35)) + v = min(255, self.d[i]["brightness"] + 35) + setBrightness(self.es[i]["id"], v) + self.d[i]["brightness"] = v a = True elif (down and pcfg): - setBrightness(self.es[i]["id"], max(1, self.prev[i]["brightness"] - 35)) + v = max(1, self.d[i]["brightness"] - 35) + setBrightness(self.es[i]["id"], v) + self.d[i]["brightness"] = v a = True return a