me/parandum
Archived
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[FIX] createProgress compatibility

Browse Source 
Wasn't previously fully backwards-compatible and its call hadn't been updated in all places
This commit is contained in:
Matthew Grove
2022-02-14 19:37:48 +00:00
parent 9c11bd2658
commit 18fd61721b
4 changed files with 37 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
functions/index.js
View File

@@ -140,12 +140,12 @@ exports.getGroupMembers = functions.https.onCall((data, context) => {
/**
* Creates new progress document.
* @param {object} data The data passed to the function.
* @param {boolean} data.ignoreCaps Whether capitalisation of answers should matter during the test.
* @param {boolean} data.ignoreCaps Whether capitalisation of answers should matter during the test. Optional.
* @param {boolean} data.limit The maximum number of lives/questions for the test.
* @param {boolean} data.mode The mode to be tested in. Valid options are "questions" and "lives".
* @param {array} data.sets An array of IDs of the desired sets.
* @param {boolean} data.showNumberOfAnswers Whether the number of answers to each prompt should be
* displayed to the user during the test.
* displayed to the user during the test. Optional.
* @param {boolean} data.switch_language Whether or not the languages should be reversed.
* @return {string} The ID of the created progress document.
*/
@@ -169,12 +169,16 @@ exports.createProgress = functions.https.onCall((data, context) => {
throw new functions.https.HttpsError("invalid-argument", "switch_language must be a boolean");
}
if (typeof data.ignoreCaps !== "boolean") {
throw new functions.https.HttpsError("invalid-argument", "ignoreCaps must be a boolean");
if (typeof data.ignoreCaps === "undefined") {
data.ignoreCaps = false;
functions.logger.log("ignoreCaps not provided - using default value of false");
} else if (typeof data.ignoreCaps !== "boolean") {
throw new functions.https.HttpsError("invalid-argument", "showNumberOfAnswers must be a boolean");
}
if (typeof data.showNumberOfAnswers === "undefined") {
data.showNumberOfAnswers = false;
functions.logger.log("showNumberOfAnswers not provided - using default value of false");
} else if (typeof data.showNumberOfAnswers !== "boolean") {
throw new functions.https.HttpsError("invalid-argument", "showNumberOfAnswers must be a boolean");
}